peterwood/finance
1
0
Fork 0
mirror of https://github.com/acedanger/finance.git synced 2025-12-05 22:50:12 -08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: migrate Font Awesome to npm package

Browse Source 
- Remove Font Awesome files from public/assets and update .gitignore
- Switch from CDN to local npm package for Font Awesome
- Update BaseLayout.astro to use Font Awesome from node_modules
- Add specific gitignore patterns for vendor files
- Keep public/assets directory structure for future custom assets

This change improves the project by:
1. Using proper dependency management through npm
2. Reducing external dependencies on CDN
3. Maintaining cleaner source control
4. Following best practices for vendor file management
This commit is contained in:
Peter Wood
2025-05-18 07:26:58 -04:00
parent 9ba3bccd56
commit a38c869770
5 changed files with 34 additions and 6768 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
.gitignore vendored
View File

@@ -7,6 +7,10 @@ dist/
# dependencies
node_modules/
# vendor files
public/assets/fontawesome/
node_modules/@fortawesome/
# logs
npm-debug.log*
yarn-debug.log*
@@ -17,6 +21,9 @@ pnpm-debug.log*
.env
.env.production
# DevContainer environment files
.devcontainer/.env
# macOS-specific files
.DS_Store
@@ -28,5 +35,3 @@ pnpm-debug.log*
# Test coverage
coverage/
# DevContainer environment files
.devcontainer/.env

2
package-lock.json generated
View File

@@ -811,6 +811,8 @@
},
"node_modules/@fortawesome/fontawesome-free": {
"version": "6.7.2",
"resolved": "https://registry.npmjs.org/@fortawesome/fontawesome-free/-/fontawesome-free-6.7.2.tgz",
"integrity": "sha512-JUOtgFW6k9u4Y+xeIaEiLr3+cjoUPiAuLXoyKOJSia6Duzb7pq+A76P9ZdPDoAoxHdHzq6gE9/jKBGXlZT8FbA==",
"license": "(CC-BY-4.0 AND OFL-1.1 AND MIT)",
"engines": {
"node": ">=6"

6765
public/assets/fontawesome/css/all.min.css vendored
View File

File diff suppressed because it is too large Load Diff

5
src/layouts/BaseLayout.astro
View File

@@ -25,7 +25,10 @@ const { title } = Astro.props;
<meta name="generator" content={Astro.generator} />
<title>{title}</title>
<link rel="stylesheet" href="/src/styles/radix-ui.css" />
<link rel="stylesheet" href="/assets/fontawesome/css/all.min.css" />
<link
rel="stylesheet"
href="/node_modules/@fortawesome/fontawesome-free/css/all.min.css"
/>
<link rel="stylesheet" href="/src/styles/global.css" />
</head>
<body>

21
src/styles/global.css
View File

@@ -417,6 +417,18 @@ tbody tr:hover {
.button-icon {
flex-shrink: 0;
display: inline-block;
width: 1em;
height: 1em;
font-size: 1rem;
vertical-align: middle;
margin-right: 0.5rem;
}
.action-btn .fa-solid {
display: inline-block !important;
font-family: "Font Awesome 6 Free", sans-serif !important;
font-weight: 900 !important;
}
.edit-btn {
@@ -638,3 +650,12 @@ tbody tr:hover {
font-size: 1.8em;
}
}
/* Adding explicit styles for each icon */
.fa-pen-to-square::before {
content: "\f14b";
}
.fa-trash-can::before {
content: "\f2ed";
}