peterwood/finance
1
0
Fork 0
mirror of https://github.com/acedanger/finance.git synced 2025-12-05 22:50:12 -08:00
Code Issues Packages Projects Releases Wiki Activity

Fix TypeScript errors in API endpoints

Browse Source
This commit is contained in:
GitHub Copilot
2025-05-06 11:38:37 +00:00
parent bfa57a9655
commit 984cd42f27
3 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/pages/api/accounts/index.ts
View File

@@ -40,12 +40,13 @@ export const POST: APIRoute = async ({ request }) => {
); );
} }
// Set default values if not provided // Set default values and ensure proper type casting
const data = { const data = {
...accountData, ...accountData,
balance: accountData.balance || 0, balance: accountData.balance ? Number(accountData.balance) : 0,
type: accountData.type || AccountType.CHECKING, type: (accountData.type as AccountType) || AccountType.CHECKING,
status: accountData.status || AccountStatus.ACTIVE, status: (accountData.status as AccountStatus) || AccountStatus.ACTIVE,
notes: accountData.notes || undefined,
}; };
// Create the account // Create the account

9
src/pages/api/transactions/[id]/index.ts
View File

@@ -1,6 +1,5 @@
import { transactionService } from '@data/db.service'; import { transactionService } from '@data/db.service';
import type { Transaction } from '@types'; import type { Transaction, TransactionStatus, TransactionType } from '@types';
import type { TransactionStatus, TransactionType } from '@types';
import type { APIRoute } from 'astro'; import type { APIRoute } from 'astro';
export const GET: APIRoute = async ({ params }) => { export const GET: APIRoute = async ({ params }) => {
@@ -73,9 +72,9 @@ export const PUT: APIRoute = async ({ request, params }) => {
if (updates.accountId !== undefined) updatedData.accountId = updates.accountId; if (updates.accountId !== undefined) updatedData.accountId = updates.accountId;
if (updates.description !== undefined) updatedData.description = updates.description; if (updates.description !== undefined) updatedData.description = updates.description;
if (updates.amount !== undefined) updatedData.amount = Number(updates.amount); if (updates.amount !== undefined) updatedData.amount = Number(updates.amount);
if (updates.category !== undefined) updatedData.category = updates.category; if (updates.category !== undefined) updatedData.category = updates.category || undefined;
if (updates.notes !== undefined) updatedData.notes = updates.notes; if (updates.notes !== undefined) updatedData.notes = updates.notes || undefined;
if (updates.tags !== undefined) updatedData.tags = updates.tags; if (updates.tags !== undefined) updatedData.tags = updates.tags || undefined;
// Convert date to Date object if it's a string // Convert date to Date object if it's a string
if (updates.date !== undefined) { if (updates.date !== undefined) {

11
src/pages/api/transactions/index.ts
View File

@@ -10,10 +10,9 @@
* - Set up proper CORS configuration * - Set up proper CORS configuration
*/ */
import { accountService, transactionService } from '@data/db.service';
import type { Transaction } from '@types';
import type { TransactionStatus, TransactionType } from '@types';
import type { APIRoute } from 'astro'; import type { APIRoute } from 'astro';
import { accountService, transactionService } from '@data/db.service';
import type { Transaction, TransactionStatus, TransactionType } from '@types';
/** /**
* TODO: API Improvements * TODO: API Improvements
@@ -63,11 +62,11 @@ export const POST: APIRoute = async ({ request }) => {
date: transactionDate, date: transactionDate,
description: transaction.description, description: transaction.description,
amount: Number(transaction.amount), amount: Number(transaction.amount),
category: transaction.category, category: transaction.category || undefined,
status: transaction.status as TransactionStatus, status: transaction.status as TransactionStatus,
type: transaction.type as TransactionType, type: transaction.type as TransactionType,
notes: transaction.notes, notes: transaction.notes || undefined,
tags: transaction.tags, tags: transaction.tags || undefined,
}); });
// Convert Decimal to number for response // Convert Decimal to number for response